Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: duplicate series being generated when using quick match #2106

Closed
dtayme opened this issue Sep 16, 2023 · 17 comments
Closed

[Bug]: duplicate series being generated when using quick match #2106

dtayme opened this issue Sep 16, 2023 · 17 comments
Labels
bug Something isn't working

Comments

@dtayme
Copy link

dtayme commented Sep 16, 2023

Describe the issue

When updating audiobook meta data using "quick match" when the series tag is populated a new entry in the series table is created. This creates multiple entries in the series view with 1 book each in those series.

Steps to reproduce the issue

  1. Fresh docker install
  2. Create a new library
  3. Run a scan on existing audiobooks (All books in root directory M4B Files generated from OpenAudible)
  4. Edit an audiobook and select "quick match"
  5. Each subsequent book in the series when using "quick match" will create a duplicate series entry.

Audiobookshelf version

2.4.2

How are you running audiobookshelf?

Docker

@dtayme dtayme added the bug Something isn't working label Sep 16, 2023
@WarHawk8080
Copy link

I concur...same problem, will also break them if I manually go in and match the book names later on

@JohanPotgieter
Copy link

I tried deleting all but one of the series. It will show the show however I can't select it. Other times it will not list any series when I start typing.

@The-Ducktor
Copy link

same issue

@Toblun
Copy link

Toblun commented Sep 16, 2023

Same issue if you us manual match, but you also get duplicate author with the same name :(
Skärmbild 2023-09-16 140726

@hobesman
Copy link

Same here. This makes the curater in me cringe. I think I'll hold off adding new books/matching existing books as much possible until this is sorted out.

@ThePlaidHatHacker
Copy link

I am seeing the same thing. I opened another bug report on series with commas in their names getting split into multiple series, so i have been tinkering with running matches and i can't find a rhyme or reason why some are getting duplicated. But I also seeing them fix themselves after a little while in some occurrences but not others.

@rikuddo91
Copy link

rikuddo91 commented Sep 17, 2023

Can confirm, having similar issue. Matched all the book in same series with similar path, but still get each book in its own series. Trying to manually add it to same series by editing doesn't help with that.
Downgrading to 2.4.0 seems to have resolved this issue (for now).

@Mavarius1989
Copy link

When you edit the audiobook and delete the other, you can select the right one qafter that out of the drop down menu.But even if there are no duplicates under "authors-menu", there are multiple ones when you edit a title in the drop down menu.
Screenshot 2023-09-17 173427

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Sep 17, 2023
@Savisthorv
Copy link

Was just about to comment the same, glad it is awaiting release, can't wait to tidy this up. Thanks!

@hobesman
Copy link

@advplyr will the planned fix address existing duplicates or just future creation of duplicates?

@advplyr
Copy link
Owner

advplyr commented Sep 17, 2023

@hobesman Unfortunately not. These can be cleaned up by using the library search and bulk edit to remove all series/authors affected. After removing re-add them. It's not ideal but writing a script to clean those on startup would take some time.

@advplyr
Copy link
Owner

advplyr commented Sep 17, 2023

Fixed in v2.4.3

@advplyr advplyr closed this as completed Sep 17, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Sep 17, 2023
@hobesman
Copy link

@hobesman Unfortunately not. These can be cleaned up by using the library search and bulk edit to remove all series/authors affected. After removing re-add them. It's not ideal but writing a script to clean those on startup would take some time.

I'm not sure how. If I try to filter by that author, I get nothing. Should I tag a random book with that author, then remove the book and re-add it? I had already retagged the orphans to go under the primary instance of that author.

Screenshot_20230917-154937_Chrome

@advplyr
Copy link
Owner

advplyr commented Sep 17, 2023

@hobesman Type the author name in the search at the top and press enter

@hobesman
Copy link

hobesman commented Sep 17, 2023

It looks like that doesn't work anyways. I switched a book from the "correct" author to one of the duplicates, then deleted that book from the db. It didn't remove the author from the search results. Now I'm scanning to re-add the deleted book but in the meantime the orphaned author entry remains. (I had 4 before and 4 after deleting the book.)

Screenshot_20230917-161557_Chrome

Are you saying I have to remove everything from Brandon Mull from the library in order to remove the empty references?

@advplyr
Copy link
Owner

advplyr commented Sep 19, 2023

Can you try renaming one of the empty authors and saving, then naming it back to the original name. That should remove the duplicate. I'll add a delete button on the author modal so these can be cleaned up in the next release easier.

The reason I didn't set it up to automatically remove empty authors is because you may have manually filled out some metadata on the author and it would get removed. I do have some logic in place for the scanner to remove authors with no books and no additional metadata but that would be difficult to trigger for this case.

@hobesman
Copy link

That worked. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests