Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Better blur for fill of ebook covers in 1:1 covers #216

Closed
superpawko opened this issue Dec 3, 2021 · 6 comments
Closed

Comments

@superpawko
Copy link

I made it for you, you can use it or not. I have edited someone else work, as my skills are low. I really love your work! So it's just a suggestion maybe someone else will have better idea. Main idea is to set background image with the same height of top image so they match.

Version 1:
https://codepen.io/superpawko/pen/WNZvqYa

Version 2:
https://codepen.io/superpawko/pen/vYeOoJj

@advplyr
Copy link
Owner

advplyr commented Dec 3, 2021

I put together some samples and some of them look better to me using the current version, and some of them look better using the increased blur. I think we need some more opinions on this, I could go either way.

image
image
image
image

@superpawko
Copy link
Author

superpawko commented Dec 3, 2021

I think 2nd option with more blur looks better, you can more focus on the cover. Of course most people will use one covers or another so this is only escape method. Thank you for you hard work! I took this idea from IRFANVIEW (SHIFT + V)
Inmo in some iteration maybe it is good idea to add title and author to the Book grid view. Because it sometimes hard to know the tile based on image only. I have for example: Seasons of stories from Storytel which have the same audiobookcover.

@advplyr
Copy link
Owner

advplyr commented Dec 3, 2021

That makes sense, it does make the cover stand out more. Do you have suggestions on how to include the title and author on the book grid?

@superpawko
Copy link
Author

Not yet, I will try prototype something for you and show best solutions , tommorrow or sunday. There are many options to consider. And there is no pefect solution. I will do some reasearch and show you what I know. So you can focus more time on develepoment.

For me the top priority where you should invest your time is chapter view in android app. (smart audiobook player) use the easiest trick by adding another timeline for chapter. I'm currently listening to 38 hour book, and it is impossible to navigate.

Thank you for you time.

advplyr added a commit that referenced this issue Dec 4, 2021
@advplyr
Copy link
Owner

advplyr commented Dec 4, 2021

I included the updated cover blur in v1.6.34

@advplyr
Copy link
Owner

advplyr commented Dec 4, 2021

Thanks for helping with designs. You can open up a discussion with those when you are ready, I'm going to close this one.

@advplyr advplyr closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants