Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash when searching for a cover without an author #2174

Closed
imcdona opened this issue Oct 2, 2023 · 1 comment
Closed

[Bug]: Crash when searching for a cover without an author #2174

imcdona opened this issue Oct 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@imcdona
Copy link

imcdona commented Oct 2, 2023

Describe the issue

Audiobookshelf crashes when trying to locate book cover without an author.

Here is the debug output:

[2023-10-02 15:51:56] DEBUG: [Audible] Search url: https://api.audible.com/1.0/catalog/products?num_results=10&products_sort_by=Relevance&title=Bimbos+of+the+Death+Sun (Audible.js:105) /server/finders/BookFinder.js:237 author = author.trim().toLowerCase() ^ TypeError: Cannot read properties of null (reading 'trim') at BookFinder.search (/server/finders/BookFinder.js:237:23) at runMicrotasks (<anonymous>) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async BookFinder.findCovers (/server/finders/BookFinder.js:339:23) at async ApiRouter.findCovers (/server/controllers/SearchController.js:29:20)

Steps to reproduce the issue

  1. Click on a book without a cover image from the library page.
  2. Click the pencil icon located on default book cover to change the cover image,
  3. Select Audible.com as the provider
  4. Remove the author from the search box and select Search
  5. Note that the websocket is disconnected upon hitting the Search button

Audiobookshelf version

v2.4.4

How are you running audiobookshelf?

Docker

@imcdona imcdona added the bug Something isn't working label Oct 2, 2023
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Oct 2, 2023
@advplyr advplyr changed the title [Bug]: Audiobookshelf crashes when searching for a cover without an author [Bug]: Crash when searching for a cover without an author Oct 2, 2023
@advplyr
Copy link
Owner

advplyr commented Oct 29, 2023

Fixed in v2.5.0

@advplyr advplyr closed this as completed Oct 29, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants