-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add an HTTPS redirect URL for OIDC support on mobile #2379
Comments
I also thought about implementing that because it is a workaround for Googles' Policy on non-https URLs, however I did not come around in doing that time wise. We probably just need a new route An Option for just using the app redirect URI is not needed. Edit: A good approach should be:
The whitelist would be in the ui and pre-filled with |
Added in v2.7.0 |
Describe the feature/enhancement
Currently, the mobile app uses the redirect URI
audiobookshelf://oauth
for the mobile app. I'm not sure how common it is for OAuth providers to support custom schemes in the redirect URI, but at least for Authelia, only thehttp
orhttps
schemes are supported (see docs). For OAuth providers with this limitation, it is not possible to use OIDC on the mobile app.I am going to quote the documentation from Immich on how this problem is solved in that application, because I think the same approach can be used here:
I think a new https endpoint should be defined on the server that redirects to
audiobookshelf://oauth
, so that this scenario can be supported.The redirect URI for the mobile app would also have to be changed to point to this new endpoint. Alternatively, the redirect URI for the mobile app could be configurable with a server setting so that users can chose to either use the new https endpoint or
audiobookshelf://oauth
as the redirect URI. This is the approach taken in Immich, though I'm not entirely sure why, since it seems simpler to just always use the HTTPS endpoint. Perhaps it was made configurable in order to avoid introducing a breaking change.The text was updated successfully, but these errors were encountered: