New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Series volume sorting with dot #261
Comments
This is a bug then, as long as it is a valid number it should be sorted as that. |
The problem is ab.book.volumeNumber is a string, if you use Number the result is: Number('1.1') // => 1.1
Number('1.10') // => 1.1 If it should works with this logic it shouldn't treated as Number and use https://www.npmjs.com/package/fast-sort#natural-sorting--language-sensitive-sorting instead |
I wasn't aware of language sensitive sorting, thanks for finding that. |
regression after changing series route 6b9ce45 |
I just pushed a patch for this, same version. |
For some series that are splitted up in multiple seasons or books i abuse the series-part with following pattern: seriesnumber.volumenumber (eg: 1.1 , 1.2 , 2.3).
The series is currently sorted: ( 1.10 , 1.1, 1.2, [...] 1.9, 2.10, 2.1 [...] ), better would be the natural sorting. ( 1.1 1.2 [...] 1.9 1.10 2.1 )
Not sure if the volume numbering overall wanted to be other than pure number or if its ok with dot.
The text was updated successfully, but these errors were encountered: