Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: When editing series set focus on inputs #889

Closed
wtanksleyjr opened this issue Aug 3, 2022 · 2 comments
Closed

[Enhancement]: When editing series set focus on inputs #889

wtanksleyjr opened this issue Aug 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@wtanksleyjr
Copy link

Describe the issue

When attempting to edit a series in a book, I expect to click the button and then type; but the resulting typing winds up in some other field.

Workaround: be paranoid, remember to always look for the blinking cursor before typing.

Proposed solution: when the Series box pops up, the keyboard focus should move to the Series box, either in the title (for new series) or in the index (for existing series).

Steps to reproduce the issue

  1. Go to Details tab in a book.
  2. Click in Description so you can see your cursor.
  3. Click the + under Series to add a series, or click the pencil icon on an existing series. Notice that the Series modal dialog pops up, and so the Description is now dimmed; but contrary to the implication of the dimming, the cursor is still in the Description and is blinking.
  4. Then begin typing; the input goes into the Description field (I expected it to go into the Series field).

Audiobookshelf version

v2.1.1

How are you running audiobookshelf?

Docker

@wtanksleyjr wtanksleyjr added the bug Something isn't working label Aug 3, 2022
@advplyr advplyr added enhancement New feature or request and removed bug Something isn't working labels Aug 3, 2022
@advplyr advplyr changed the title [Bug]: When editing book data, the series popup doesn't receive cursor focus [Enhancement]: When editing book data, the series popup doesn't receive cursor focus Aug 3, 2022
@advplyr advplyr changed the title [Enhancement]: When editing book data, the series popup doesn't receive cursor focus [Enhancement]: When editing series set focus on inputs Aug 3, 2022
@advplyr
Copy link
Owner

advplyr commented Aug 3, 2022

Agree this is a nice feature. Updated for the next release.

@advplyr
Copy link
Owner

advplyr commented Aug 6, 2022

Added in v2.1.2

@advplyr advplyr closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants