Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[(Very) Minor Enhancement]: Include author name in toasts #992

Closed
raviwarrier opened this issue Sep 17, 2022 · 3 comments
Closed

[(Very) Minor Enhancement]: Include author name in toasts #992

raviwarrier opened this issue Sep 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@raviwarrier
Copy link

raviwarrier commented Sep 17, 2022 •
edited

Describe the feature/enhancement

It's impossible to know which author wasn't updated and which author wasn't found. It would be nice if the toasts read "No updates were made for [author name]" or "[author name] not found"...

image
@raviwarrier raviwarrier added the enhancement New feature or request label Sep 17, 2022
@raviwarrier
Copy link
Author

raviwarrier commented Sep 17, 2022 •
edited

Apparently, the author name shows up when I clicked the "Match all authors" button (the one on the top right)...

image

In the OP image, I had clicked on the 'magnifying glass' icon over each author box...

@advplyr
Copy link
Owner

advplyr commented Sep 17, 2022

That can be updated. I would have put the author name in the match all because otherwise you wouldn't know which one was not found, but I can see it being useful when clicking on the quick match directly on the author too.

advplyr added a commit that referenced this issue Sep 18, 2022
@advplyr
Update:Add author name to author quickmatch toast #992
565bb4c
@advplyr
Copy link
Owner

advplyr commented Oct 2, 2022

Updated in v2.2.0

@advplyr advplyr closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raviwarrier @advplyr