Implement a Settings Content component #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new settings conent component. This is a container component for the settings pages, so that they all get the same formatting by default. It handles the header text, description text, and any "add new" plus button as needed.
This commit moves the library settings page over to use the new component. This page is 1 of 2 that actually has a component for itself, so it was mostly just modifying that existing component and wrapping it
This commit moves the Users settings page to use the new Settings Content component. Similar to the Libraries page, this one is already a component. I mimiced the behavior of the existing libraries component to get the same functionality needed here
This commit moves the Backup page to use the new settings component. As part of this, I had to do a little bit of modification for some of the strings, as I cleaned up the way the strings are laid out on the page.
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous commits, we consolidated all of the settings pages to have the same styling. This commit takes that one step further by extracting out all of that logic to a singular component. This component wraps the content of the settings pages themselves, so it is very easy to use. As well, it has the functionality to pass through the header text, description text, and a method that could be needed to "add a new one" of something for the page (users, libraries, etc.).