Server respond with objects #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - `findAll` (GET /api/libraries) - `getLibraryUserPersonalizedOptimal` (GET /api/libraries/<ID>/personalized) - `getAuthors` (GET /api/libraries/<ID>/authors) - `reorder` (POST /api/libraries/order)
Changes: - `batchGet` (POST /api/items/batch/get)
Changes: - `findAll` (GET /api/users)
Changes: - `findAll` (GET /api/collections)
Changes: - `getPaths` (GET /api/filesystem)
Changes: - `search` (GET /api/authors/search)
Changes: - `search` (GET /api/series/search)
Changes: - `findCovers` (GET /api/search/covers) - `findBooks` (GET /api/search/books) - `findPodcasts` (GET /api/search/podcast)
Changes: - `getAllTags` (GET /api/tags)
|
I realize now a lot of these are used in the mobile app. Collections, libraries, shelves, etc. so this is going to have to wait until the next mobile app release. |
|
Unfortunately I missed the Since I want to merge this without waiting for another mobile app release we will have to lease those 3 out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on matrix, this updates the server so that it always responds with an object, never an array. This simplifies processing the response for clients in other languages. I didn't actually test the changes so that probably should be done before merging.