Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a shot at doing localization with date-fns
I do not like the lines
from https://github.com/advplyr/audiobookshelf/blob/master/client/plugins/init.client.js
but for the love of god, I could not simply do a
import locale from 'date-fns/locale'
just like stated in the docsThere must be a better way, but this one works...
I also took the liberty to generate the months and weekdays through date-fns format function. I think this render
audiobookshelf/client/strings/en-us.json
Lines 630 to 643 in 5724887
and
audiobookshelf/client/strings/en-us.json
Lines 536 to 547 in 5724887
useless