Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FantLab.ru BookFinder #1487

Merged
merged 6 commits into from
Feb 11, 2023
Merged

FantLab.ru BookFinder #1487

merged 6 commits into from
Feb 11, 2023

Conversation

Nab0y
Copy link
Contributor

@Nab0y Nab0y commented Feb 6, 2023

I've added a new book match provider. fantlab.ru is a huge site with tens of thousands of book descriptions in Russian and not only (Russian is still the main language).
This is my first js code, my main activity is a .net developer. So if there are simple errors in the implementation, then please do not kick hard. :)
image
image

server/providers/FantLab.js Outdated Show resolved Hide resolved
server/providers/FantLab.js Outdated Show resolved Hide resolved
server/providers/FantLab.js Outdated Show resolved Hide resolved
server/providers/FantLab.js Outdated Show resolved Hide resolved
server/providers/FantLab.js Show resolved Hide resolved
@advplyr
Copy link
Owner

advplyr commented Feb 7, 2023

Thanks! This one is tough for me because the API docs are in Russian.

Can you clean up:

  1. Replace var with const or let. I recently stopped using var and have been replacing this slowly throughout the project. var can be instantiated inside an if statement but accessible outside the if statement which can be confusing. See line 75 in your PR.
  2. Removing semicolons

@Nab0y
Copy link
Contributor Author

Nab0y commented Feb 8, 2023

Code cleared of semicolons and var

server/providers/FantLab.js Outdated Show resolved Hide resolved
server/providers/FantLab.js Outdated Show resolved Hide resolved
Dmitry and others added 2 commits February 9, 2023 23:09
Co-authored-by: advplyr <67830747+advplyr@users.noreply.github.com>
@advplyr
Copy link
Owner

advplyr commented Feb 11, 2023

Thanks!

@advplyr advplyr merged commit 5d40fdf into advplyr:master Feb 11, 2023
@slyfoxgh
Copy link

slyfoxgh commented Feb 13, 2024

Edit - February 13, 2024 - It started working again. The must have been an issue with the API or FantLab.

Did the search stopped working? I can't match any Russian books anymore.

`audiobookshelf-audiobookshelf-1 | [2024-02-13 03:34:42.578] INFO: [Audnexus] Searching for author "https://api.audnex.us/authors?name=%D0%B1%D0%B5%D1%81%D1%82%D0%B5%D1%80"

audiobookshelf-audiobookshelf-1 | [2024-02-13 03:34:42.583] INFO: [Audnexus] Searching for author "https://api.audnex.us/authors?name=%D1%84%D0%B5%D0%BD%D0%BE%D0%BC%D0%B5%D0%BD%20%D0%B8%D1%81%D1%87%D0%B5%D0%B7%D0%BD%D0%BE%D0%B2%D0%B5%D0%BD%D0%B8%D1%8F"

audiobookshelf-audiobookshelf-1 | [2024-02-13 03:35:02.660] INFO: [Audnexus] Searching for author "https://api.audnex.us/authors?name=%D0%B1%D0%B5%D1%81%D1%82%D0%B5%D1%80"

audiobookshelf-audiobookshelf-1 | [2024-02-13 03:35:02.663] INFO: [Audnexus] Searching for author "https://api.audnex.us/authors?name=%D1%84%D0%B5%D0%BD%D0%BE%D0%BC%D0%B5%D0%BD%20%D0%B8%D1%81%D1%87%D0%B5%D0%B7%D0%BD%D0%BE%D0%B2%D0%B5%D0%BD%D0%B8%D1%8F"
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants