Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to the backup page #2133

Merged
merged 6 commits into from Sep 22, 2023
Merged

Conversation

mfcar
Copy link
Contributor

@mfcar mfcar commented Sep 20, 2023

This pull request adds more information to the backup page:

  • The backup location path and
  • Name when downloading a backup file
Screenshot 2023-09-20 at 22 37 51 Screenshot 2023-09-20 at 22 38 05

@advplyr
Copy link
Owner

advplyr commented Sep 22, 2023

I thought that adding another api endpoint for getting the location felt like overkill so I added the backupLocation to the get all backups api endpoint instead.
I also moved the backup location path to be above the "Enable automatic backups" setting. It doesn't look as clean but it wasn't specific to automatic backups so I didn't want to group it in with that setting.
Thanks!

@advplyr advplyr merged commit 102c90c into advplyr:master Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants