Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get more data from opf #218

Merged
merged 4 commits into from Dec 4, 2021
Merged

Get more data from opf #218

merged 4 commits into from Dec 4, 2021

Conversation

kaldigo
Copy link
Contributor

@kaldigo kaldigo commented Dec 4, 2021

When there is html in the description on a opf file it will strip it rather than not returning. It also gets series and volume number from the opf.

@Helico-Pter
Copy link

I was just thinking it would be great if 'series' could be read from the file.

@advplyr
Copy link
Owner

advplyr commented Dec 4, 2021

Thanks, I had been meaning to eventually use the strip html package there.

Can you move this meta check 6e621ec#diff-3ddb151b8ce6aa69c5d2527e033c0aac28a2c4873111ffb0948fa37bb951fbe1R59
into the parseOpfMetadataXML function instead of xmlToJson. xmlToJson might eventualy be used for something other than Opf files.

@kaldigo
Copy link
Contributor Author

kaldigo commented Dec 4, 2021

Done. I also change the series page to sort alphabetically and on the series pages to sort by volume number as a number not alphabetically.

@advplyr advplyr merged commit 415b58e into advplyr:master Dec 4, 2021
@advplyr
Copy link
Owner

advplyr commented Dec 4, 2021

This is released in v1.6.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants