-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few BookFinder improvements (including a fix for #2238) #2400
Conversation
Works great, thanks! |
#2517 there is a case I didn't think of where audible returns a bunch of results that are bad matches but if one of those matches has a closer duration it will show up at the top. |
So, there's a filterSearchResults function that tries to do this (but only for OpenLib results). I'll look into it once more, and perhaps change the current implementation so it works well for all providers. |
But, just to be clear, even if it is better implemented, I think filterSearchResults is just a patch. I think that for the purpose of running Quick Match on a large scale, what we really need is to have a confidence score for the top result. If it is above some threshold, we automatically match, if not, we mark it and let the user review - I know I want this feature badly... it's the only way I'm going to be able to get some order into my library :) |
The following improvements were implemented: