Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to custom metadata provider schema #2891

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ahobsonsayers
Copy link
Contributor

When developing my custom metadata provider, I noticed a couple of issues with the provider schema that I thought I would fix. I also did a bit of minor tidy up (I hope this is ok, If not let me know and I will revert!)

Schema changes:

  • duration type should be an integer not a number
  • I have split out SeriesMetadata to its own component, as this will generate its own type for those who use generators with the schema, instead of nested anonymous objects.
  • series under SeriesMetadata being required was specified in the incorrect way using required: <bool> instead of required: <property array>
  • sequence under SeriesMetadata should not be a number, it should be a string to allow for sequences like 0.5, 1-3 and 1,3,5

Let me know if there is any changes you would like me to make!

@advplyr
Copy link
Owner

advplyr commented Apr 29, 2024

LGTM thanks!

@advplyr advplyr merged commit c559881 into advplyr:master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants