feat: Updates to docker file and gh action #664
Conversation
hskrtich
commented
Jun 2, 2022
hskrtich
commented
- Clean up Dockerfile
- Add health check to Dockerfile 662
- Update gh action versions
- Update manual trigger to include input 661
* Clean up Dockerfile * Add health check to Dockerfile * Update gh action versions
| RUN apk update && \ | ||
| apk add --no-cache --update \ | ||
| curl \ | ||
| tzdata \ |
There was a problem hiding this comment.
What does timezone data do for us here? Is that for the healthcheck?
There was a problem hiding this comment.
It allows me to change the timezone inside the container using an environment var. From what I've heard the server doesnt respect the timezone yet but it can be usefull for running other commands. I also wanted to look into seeing what it would take to use the local timezone in the logs.
There was a problem hiding this comment.
I can remove it if you want.
There was a problem hiding this comment.
I'm not sure how that works. If we wanted to add the timezone as an environment var wouldn't we need to set env using the ENV command?
There was a problem hiding this comment.
The tzdata package automatically picks up the TZ env and uses it to set the timezone inside the container.
|
Tried out the manually build with tag input and build is failing. |
