Clear selectedEpisodes on download. #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…you can't select existing downloads
|
Idiot move on my part making a PR 10 minute after looking at the code for the first time. Will reopen tomorrow with a proper fix. |
|
I'm looking through this modal and it is a mess so I'm going to make some more updates in your PR. I also think the toggle shouldn't requiring clicking the checkbox. |
|
Sounds good. As for the toggle, do you mean it should active by clicking clicking anywhere on the line? Also, the setting of selected episodes in the init method seems unnecessary. |
|
Yeah that's what I mean and yeah the init is unnecessary. I'm going to do a refactor now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears the selectedEpisodes once the download is started. Fixes #931.
Also, clicking on the checkbox for existing downloads still added that item to the list. Moved onClick to checkbox instead of container div to prevent this.