Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More debugging and error checking #12

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Conversation

adybbroe
Copy link
Owner

@adybbroe adybbroe commented Oct 20, 2022

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest
  • Passes flake8
  • Fully documented

Adam.Dybbroe added 4 commits September 12, 2022 10:23
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…found

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…ceeding

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Oct 20, 2022
@adybbroe adybbroe added the enhancement New feature or request label Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #12 (970e8f6) into main (4ea9441) will increase coverage by 1.21%.
The diff coverage is 90.45%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   73.91%   75.13%   +1.21%     
==========================================
  Files          18       20       +2     
  Lines        1775     1910     +135     
  Branches      191      188       -3     
==========================================
+ Hits         1312     1435     +123     
- Misses        439      450      +11     
- Partials       24       25       +1     
Flag Coverage Δ
unittests 75.13% <90.45%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
activefires_pp/tests/test_messaging.py 100.00% <ø> (ø)
activefires_pp/geometries_from_shapefiles.py 80.95% <20.00%> (-6.23%) ⬇️
activefires_pp/spatiotemporal_alarm_filtering.py 77.09% <63.63%> (-0.19%) ⬇️
activefires_pp/post_processing.py 50.38% <64.28%> (-0.02%) ⬇️
activefires_pp/api_posting.py 83.33% <83.33%> (+16.66%) ⬆️
activefires_pp/tests/conftest.py 93.33% <93.33%> (ø)
activefires_pp/config.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_api_posting.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_config.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_fires_filtering.py 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coveralls
Copy link

coveralls commented Oct 20, 2022

Coverage Status

Coverage increased (+0.2%) to 76.44% when pulling 970e8f6 on more-debugging-and-error-checking into 6463205 on main.

Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with more debug messages. A couple of typos and a question inline.

activefires_pp/post_processing.py Outdated Show resolved Hide resolved
activefires_pp/tests/conftest.py Outdated Show resolved Hide resolved
activefires_pp/tests/test_fires_filtering.py Outdated Show resolved Hide resolved
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe merged commit 4774ee3 into main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants