Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add unique detection #16

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Conversation

adybbroe
Copy link
Owner

@adybbroe adybbroe commented Jul 12, 2023

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest
  • Passes flake8
  • Fully documented

Adam.Dybbroe added 2 commits April 24, 2023 12:18
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Jul 12, 2023
@adybbroe adybbroe added the enhancement New feature or request label Jul 12, 2023
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #16 (a79ebbd) into main (46b894f) will increase coverage by 3.49%.
The diff coverage is 86.55%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   77.45%   80.94%   +3.49%     
==========================================
  Files          20       21       +1     
  Lines        2000     2299     +299     
  Branches      192      350     +158     
==========================================
+ Hits         1549     1861     +312     
+ Misses        422      406      -16     
- Partials       29       32       +3     
Flag Coverage Δ
unittests 80.94% <86.55%> (+3.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
activefires_pp/tests/test_geojson_utils.py 100.00% <ø> (ø)
activefires_pp/post_processing.py 64.53% <53.70%> (+8.50%) ⬆️
...efires_pp/tests/test_fire_detection_id_handling.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_fire_notifications.py 98.76% <100.00%> (-0.03%) ⬇️
activefires_pp/tests/test_fires_filtering.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_messaging.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Adam.Dybbroe added 3 commits July 13, 2023 14:50
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@coveralls
Copy link

coveralls commented Jul 13, 2023

Coverage Status

coverage: 82.34% (+3.4%) from 78.9% when pulling a79ebbd on feature-add-unique-detection-id into 46b894f on main.

Adam.Dybbroe added 6 commits July 13, 2023 16:36
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…trolled or uncontrolled)

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe merged commit 228aadb into main Jul 14, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants