Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify products to notify #19

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

adybbroe
Copy link
Owner

@adybbroe adybbroe commented Aug 28, 2023

This PR adds an option to allow specifying in the configuration which (national) products should trigger notifications

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest
  • Passes flake8
  • Fully documented

Adam.Dybbroe added 2 commits August 28, 2023 21:08
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Aug 28, 2023
@adybbroe adybbroe added the enhancement New feature or request label Aug 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #19 (1835753) into main (21c7a1a) will increase coverage by 0.24%.
The diff coverage is 95.34%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   80.94%   81.19%   +0.24%     
==========================================
  Files          21       21              
  Lines        2299     2340      +41     
  Branches      350      362      +12     
==========================================
+ Hits         1861     1900      +39     
- Misses        406      408       +2     
  Partials       32       32              
Flag Coverage Δ
unittests 81.19% <95.34%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
activefires_pp/tests/test_messaging.py 100.00% <ø> (ø)
activefires_pp/fire_notifications.py 38.96% <81.81%> (+1.24%) ⬆️
activefires_pp/tests/test_fire_notifications.py 99.11% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coveralls
Copy link

Coverage Status

coverage: 82.564% (+0.2%) from 82.34% when pulling 1835753 on allow-specify-products-to-notify into 21c7a1a on main.

Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud
Copy link
Collaborator

mraspaud commented Sep 7, 2023

@adybbroe I'll let you fix the merge conflicts

@adybbroe adybbroe merged commit fcc586c into main Sep 8, 2023
19 checks passed
@mraspaud mraspaud deleted the allow-specify-products-to-notify branch September 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants