Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug updating the detection id while running more than one day #20

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

adybbroe
Copy link
Owner

@adybbroe adybbroe commented Sep 8, 2023

This PR should solve a bug found in the recently introduce addition to include a unique detection id.
The initialization was always reading from the cache file, and thus the date was never updated.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest
  • Passes flake8
  • Fully documented

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Sep 8, 2023
Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice with the new tests! some comments.

activefires_pp/post_processing.py Outdated Show resolved Hide resolved
activefires_pp/tests/conftest.py Outdated Show resolved Hide resolved
activefires_pp/tests/test_fire_detection_id_handling.py Outdated Show resolved Hide resolved
activefires_pp/tests/test_fire_detection_id_handling.py Outdated Show resolved Hide resolved
activefires_pp/tests/test_fire_detection_id_handling.py Outdated Show resolved Hide resolved
activefires_pp/tests/test_fire_detection_id_handling.py Outdated Show resolved Hide resolved
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #20 (582f71c) into main (fcc586c) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   82.55%   82.73%   +0.17%     
==========================================
  Files          21       21              
  Lines        2540     2554      +14     
  Branches      379      386       +7     
==========================================
+ Hits         2097     2113      +16     
+ Misses        412      410       -2     
  Partials       31       31              
Flag Coverage Δ
unittests 82.73% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
activefires_pp/post_processing.py 66.21% <100.00%> (+0.22%) ⬆️
activefires_pp/tests/conftest.py 96.22% <100.00%> (+1.86%) ⬆️
...efires_pp/tests/test_fire_detection_id_handling.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coveralls
Copy link

coveralls commented Oct 2, 2023

Coverage Status

coverage: 83.947% (+0.2%) from 83.78%
when pulling 81635c8 on fix-bug-detection-id
into fcc586c on main.

@adybbroe
Copy link
Owner Author

Are you okay with this now @mraspaud Can we merge?

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe merged commit ac3f5b6 into main Dec 14, 2023
19 of 21 checks passed
@adybbroe adybbroe added the bug Something isn't working label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants