-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bug updating the detection id while running more than one day #20
Conversation
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice with the new tests! some comments.
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 82.55% 82.73% +0.17%
==========================================
Files 21 21
Lines 2540 2554 +14
Branches 379 386 +7
==========================================
+ Hits 2097 2113 +16
+ Misses 412 410 -2
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Are you okay with this now @mraspaud Can we merge? |
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR should solve a bug found in the recently introduce addition to include a unique detection id.
The initialization was always reading from the cache file, and thus the date was never updated.
pytest
flake8