-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to discard spurious detections with very low FRP and high TB(I-Band 4) #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
…ed by high energy radiation in the sensor Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
mraspaud
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one simple comment.
And then the other open pull request has been put here too, I think this should be cleaned up.
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
…fil filter class Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
mraspaud
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…K in order to reject the detection as a spurious one Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a sanity check on the Active Fires data so as to remove any spurious detections where the I-band 4 TB is very high but the M-band based FRP is very low. These data indicate a glitch onboard known to affect the I-Band number 4 over the SAA (South Atlantic magnetic Anamoly) zone, but also can happen elsewhere. See figure below.
The filtering is applied after the national shapefile filtering.
pytest
flake8
Below is an example of known errors that is supposed to be filtered out with the new check.
The points far to the right (TB=367 K - saturation) is from the outgassing event of NOAA-21 end of February 2024
The new sanity-check introduced in this PR will reject detections as spurious where the TB(I-band 4)/FRP is greater than 1000 and the TB(I-band 4) is greater than 310 K.