Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to discard spurious detections with very low FRP and high TB(I-Band 4) #22

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

adybbroe
Copy link
Owner

@adybbroe adybbroe commented Apr 12, 2024

This PR add a sanity check on the Active Fires data so as to remove any spurious detections where the I-band 4 TB is very high but the M-band based FRP is very low. These data indicate a glitch onboard known to affect the I-Band number 4 over the SAA (South Atlantic magnetic Anamoly) zone, but also can happen elsewhere. See figure below.

The filtering is applied after the national shapefile filtering.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest
  • Passes flake8
  • Fully documented

Below is an example of known errors that is supposed to be filtered out with the new check.

frp_vs_tb4_viirs_satellites_2023_2024_nightime

The points far to the right (TB=367 K - saturation) is from the outgassing event of NOAA-21 end of February 2024

The new sanity-check introduced in this PR will reject detections as spurious where the TB(I-band 4)/FRP is greater than 1000 and the TB(I-band 4) is greater than 310 K.

Adam.Dybbroe added 3 commits April 12, 2024 15:03
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
…ed by high energy radiation in the sensor

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe self-assigned this Apr 14, 2024
@adybbroe adybbroe added the enhancement New feature or request label Apr 14, 2024
Adam.Dybbroe added 2 commits April 14, 2024 19:11
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@coveralls
Copy link

coveralls commented Apr 14, 2024

Coverage Status

coverage: 84.41% (+0.3%) from 84.106%
when pulling cfa2362 on discard-spurious-detections
into f1a0524 on main.

@adybbroe adybbroe marked this pull request as ready for review April 14, 2024 18:24
@adybbroe adybbroe requested a review from mraspaud April 15, 2024 08:02
Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one simple comment.
And then the other open pull request has been put here too, I think this should be cleaned up.

activefires_pp/post_processing.py Outdated Show resolved Hide resolved
activefires_pp/tests/test_messaging.py Outdated Show resolved Hide resolved
Adam.Dybbroe added 2 commits April 17, 2024 18:05
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
…fil filter class

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe requested a review from mraspaud April 17, 2024 16:41
Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adam.Dybbroe added 2 commits April 18, 2024 10:11
…K in order to reject the detection as a spurious one

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe merged commit 87e3bb7 into main Apr 18, 2024
17 of 19 checks passed
@mraspaud mraspaud deleted the discard-spurious-detections branch April 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants