Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature alarm filtering #9

Merged
merged 13 commits into from
Jul 15, 2022
Merged

Feature alarm filtering #9

merged 13 commits into from
Jul 15, 2022

Conversation

adybbroe
Copy link
Owner

@adybbroe adybbroe commented Jul 13, 2022

Add functionality to filter fire detections (alarms) in space and time.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8
  • Fully documented

Adam.Dybbroe added 6 commits July 11, 2022 13:30
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
# Conflicts:
#	activefires_pp/post_processing.py
#	activefires_pp/tests/test_utils.py
#	activefires_pp/utils.py
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #9 (4bd5b51) into main (63679fc) will increase coverage by 10.45%.
The diff coverage is 89.97%.

@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   63.46%   73.91%   +10.45%     
===========================================
  Files          11       18        +7     
  Lines        1114     1775      +661     
  Branches      133      191       +58     
===========================================
+ Hits          707     1312      +605     
- Misses        389      439       +50     
- Partials       18       24        +6     
Flag Coverage Δ
unittests 73.91% <89.97%> (+10.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
activefires_pp/tests/test_fire_notifications.py 98.79% <ø> (-0.06%) ⬇️
activefires_pp/tests/test_fires_filtering.py 100.00% <ø> (ø)
activefires_pp/post_processing.py 50.39% <50.00%> (ø)
activefires_pp/fire_notifications.py 37.72% <60.00%> (+0.82%) ⬆️
activefires_pp/api_posting.py 66.66% <66.66%> (ø)
activefires_pp/spatiotemporal_alarm_filtering.py 77.27% <77.27%> (ø)
activefires_pp/geojson_utils.py 95.74% <95.74%> (ø)
...es_pp/tests/test_spatiotemporal_alarm_filtering.py 98.28% <98.28%> (ø)
activefires_pp/config.py 100.00% <100.00%> (ø)
activefires_pp/tests/test_config.py 100.00% <100.00%> (ø)
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@coveralls
Copy link

coveralls commented Jul 14, 2022

Coverage Status

Coverage increased (+10.2%) to 75.268% when pulling 4bd5b51 on feature-alarm-filtering into 63679fc on main.

Adam.Dybbroe added 6 commits July 14, 2022 16:47
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…rage

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Jul 15, 2022
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe merged commit 4ba7f17 into main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants