-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README and example projects #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5020f44
to
de27fd8
Compare
325016c
to
fb1992f
Compare
fb1992f
to
92f6944
Compare
Use VelocidiSDKTests no longer a shared target. Remove use of deprecated function. Fix code coverage reports to codecov configurations. Remove additional SDK 'i' warning
92f6944
to
7332b4e
Compare
antonio-ramadas
suggested changes
May 23, 2019
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
antonio-ramadas
suggested changes
May 23, 2019
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
798f275
to
d394ec1
Compare
antonio-ramadas
suggested changes
May 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the Swift tutorial on how to create a custom event 👏
Most (if not all) changes required are all pretty small.
c618862
to
7de9e79
Compare
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com> Update README.md Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
7de9e79
to
2f87b04
Compare
antonio-ramadas
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add two example projects (one in Swift and another in Objc) and also update the README with examples from said example projects.
Both applications only have a button, to force a tracking request, and a text label to show the result of said tracking request.
This PR also includes: