Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README and example projects #4

Merged
merged 35 commits into from
May 28, 2019
Merged

Conversation

duartepinto
Copy link
Contributor

@duartepinto duartepinto commented Apr 24, 2019

In this PR I add two example projects (one in Swift and another in Objc) and also update the README with examples from said example projects.

Both applications only have a button, to force a tracking request, and a text label to show the result of said tracking request.

This PR also includes:

  • Fix codecov reports by ignoring Pod files
  • Use xcpretty in travis

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #4 into master will increase coverage by 46.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   19.92%   66.05%   +46.13%     
===========================================
  Files         177       47      -130     
  Lines        9136      436     -8700     
===========================================
- Hits         1820      288     -1532     
+ Misses       7316      148     -7168
Impacted Files Coverage Δ
VelocidiSDK/VelocidiSDKTests/VelocidiTests.swift 92.98% <100%> (ø) ⬆️
.../Sources/Nimble/Adapters/NimbleXCTestHandler.swift
...ONModel/JSONModelNetworking/JSONModel+networking.m
...orking/AFNetworking/AFNetworkReachabilityManager.h
...orking/AFNetworking/AFNetworkReachabilityManager.m
Pods/Quick/Sources/QuickObjectiveC/QuickSpec.m
Pods/Mockingjay/Sources/Mockingjay/Builders.swift
...g/UIKit+AFNetworking/UIProgressView+AFNetworking.m
...ods/Nimble/Sources/Nimble/Matchers/ToSucceed.swift
...ds/Nimble/Sources/Nimble/Matchers/MatchError.swift
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c937f7...2f87b04. Read the comment docs.

@duartepinto duartepinto marked this pull request as ready for review May 21, 2019 16:43
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Examples/SwiftExample/SwiftExample/ViewController.swift Outdated Show resolved Hide resolved
Examples/SwiftExample/SwiftExample/ViewController.swift Outdated Show resolved Hide resolved
Examples/SwiftExample/SwiftExample/ViewController.swift Outdated Show resolved Hide resolved
Examples/README.md Show resolved Hide resolved
Examples/Podfile.lock Outdated Show resolved Hide resolved
duartepinto and others added 4 commits May 23, 2019 14:03
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
duartepinto and others added 4 commits May 23, 2019 14:11
duartepinto and others added 4 commits May 23, 2019 14:22
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
duartepinto and others added 2 commits May 23, 2019 16:18
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
Copy link
Contributor

@antonio-ramadas antonio-ramadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the Swift tutorial on how to create a custom event 👏

Most (if not all) changes required are all pretty small.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>

Update README.md

Co-Authored-By: António Ramadas <antonio_ramadas@hotmail.com>
@antonio-ramadas antonio-ramadas merged commit 4a408e5 into master May 28, 2019
@antonio-ramadas antonio-ramadas deleted the example-project branch May 28, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants