Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/aeagle/react-spaces/issues/49 #55

Closed
wants to merge 1 commit into from
Closed

Fix for https://github.com/aeagle/react-spaces/issues/49 #55

wants to merge 1 commit into from

Conversation

thekapadia
Copy link

Hi @aeagle - our team investigated #49 - and we found it to be a problem when resizable={true} and scrollable={true} - both are enabled.

This change in the Space.tsx file helped fix it. Please review.

Note: Please ignore the whitespaces in the diff.

@thekapadia
Copy link
Author

@aeagle Any thoughts on this?

@thekapadia
Copy link
Author

Hi @aeagle - did you get a chance to look into this PR?

@aeagle
Copy link
Owner

aeagle commented Jan 8, 2020

Hi @thekapadia. My concern with the PR is that it reverses my effort to reduce the markup created by the spaces. The only scenario at the moment where an inner/outer element is required is when a space is resizable and scrollable to properly position the resize handle. At the moment, the change applied by this PR will generate an inner/outer element for all spaces. I am going to see if there is a way to position the resize handle in a scrollable space without requiring the inner/outer element as that would be the ideal solution.

@thekapadia
Copy link
Author

Sure @aeagle, your concern is reasonable.

@aeagle aeagle closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants