Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After turning off Sync Clippings, the old Synced Clippings folder incorrectly retains its special icon #244

Closed
aecreations opened this issue Dec 6, 2018 · 1 comment
Assignees

Comments

@aecreations
Copy link
Owner

This is a leftover issue caused by the fix for issue #243. The Synced Clippings folder incorrectly retains its special folder icon in the Clippings menu after turning off Sync Clippings, but the user has chosen not to remove the folder.

There is a solution: from the Mozilla Add-ons Blog: https://blog.mozilla.org/addons/2018/11/08/extensions-in-firefox-64/

browser.menus.update() now allows extensions to update an icon without having to delete and recreate the menu item.

However, this requires Firefox 64 or newer, hence the deferral of a fix for this issue to post-6.1, as version 6.1 needs to be compatible with Firefox 60 ESR.

@aecreations aecreations added the bug label Dec 6, 2018
@aecreations aecreations self-assigned this Dec 6, 2018
@aecreations aecreations changed the title After turning off Sync Clippings, change icon of old Synced Clippings folder After turning off Sync Clippings, the old Synced Clippings folder incorrectly retains its special icon Dec 6, 2018
@aecreations
Copy link
Owner Author

It is not desirable to force a menu rebuild after turning off Sync Clippings, since a rebuild will happen again after removing the Synced Clippings folder (if the user has chosen to leave the default option to do so). Two menu rebuilds in quick succession can cause menu corruption problems.

@aecreations aecreations added this to To Do in Clippings 6.1 Dec 6, 2018
@aecreations aecreations moved this from To Do to In Progress in Clippings 6.1 Dec 10, 2018
@aecreations aecreations added this to the 6.1.1 Coronado milestone Dec 11, 2018
aecreations added a commit that referenced this issue Dec 11, 2018
…older incorrectly retains its special icon (issue #244)

- Requires Firefox 64 or newer; will have no effect on older versions.
@aecreations aecreations moved this from In Progress to Done in Clippings 6.1 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Clippings 6.1
  
Done
Development

No branches or pull requests

1 participant