Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First-time backup notification not appearing #251

Closed
aecreations opened this issue Dec 20, 2018 · 3 comments
Closed

First-time backup notification not appearing #251

aecreations opened this issue Dec 20, 2018 · 3 comments
Assignees
@aecreations
Labels
bug fixed
Projects
Clippings 6.1
Milestone
6.1.2 Balboa Park

Comments

@aecreations
Copy link
Owner

Clippings 6.1.1

A severe bug that is causing the first-time backup reminder notification to never appear. The last backup reminder date/time pref, gPrefs.lastBackupRemDate is always being reset to the time that Firefox was launched.

This bug won't occur if the user changes the default reminder frequency setting from Clippings preferences, which would unset the first-time backup reminder flag gPrefs.backupRemFirstRun, and causes the normal reminder notifications to appear when the duration between reminders has elapsed.
@aecreations aecreations self-assigned this Dec 20, 2018
@aecreations aecreations added this to the 6.1.2 Balboa Park milestone Dec 20, 2018
@aecreations aecreations added this to To Do in Clippings 6.1 Dec 20, 2018
@aecreations aecreations moved this from To Do to In Progress in Clippings 6.1 Dec 20, 2018
aecreations added a commit that referenced this issue Dec 20, 2018
@aecreations
Bug fix: First-time backup notification not appearing (issue #251)
64601ef
@aecreations
Copy link
Owner Author

Testing that this works by hacking the backup reminder frequency to daily (instead of default 7 days). I expect the first-time notification to appear in Firefox Developer Edition on my iMac on Thursday, Dec. 20th at ~10:07pm.

@aecreations
Copy link
Owner Author

Confirmed fixed. First-time backup notification appeared.

@aecreations aecreations moved this from In Progress to Done in Clippings 6.1 Dec 21, 2018
@aecreations aecreations moved this from Done to In Progress in Clippings 6.1 Dec 23, 2018
@aecreations aecreations removed the fixed label Dec 23, 2018
@aecreations
Copy link
Owner Author

Should also force the first-time backup reminder to appear after the upgrade from 6.1.1 to 6.1.2.

aecreations added a commit that referenced this issue Dec 24, 2018
@aecreations
Force display the first-time backup reminder after upgrade from 6.1.1
69a78b3 
(part of issue #251)
@aecreations aecreations moved this from In Progress to Done in Clippings 6.1 Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aecreations aecreations

Labels
bug fixed
Projects
No open projects
Clippings 6.1
  
Done
Milestone
6.1.2 Balboa Park
Development

No branches or pull requests
1 participant
@aecreations