Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION: Keyboard shortcuts in windows and dialogs doesn't do anything #254

Closed
aecreations opened this issue Jan 14, 2019 · 2 comments
Closed
Assignees

Comments

@aecreations
Copy link
Owner

Clippings 6.1.2+ on Firefox 65.0b10

Major regression issue discovered on Firefox 65 beta.

In Clippings Manager, pressing keys such as F1 (for Clippings Manager keyboard shortcut help), DEL (to delete a clipping or folder), CTRL+Z or Cmd+Z (undo), and so on, have no effect. And when pressing CTRL+F/Cmd+F (search clipping/folder by name), the browser's search bar appears instead.

In the other dialogs, pressing ENTER (accept button action) or ESC (cancel) doesn't work, either. In the keyboard paste dialog, pressing TAB doesn't toggle between search by name and shortcut key paste, and F1 no longer displays the list of shortcuts.

This issue is not happening on Firefox 64.

@aecreations aecreations self-assigned this Jan 14, 2019
@aecreations aecreations changed the title Keyboard shortcuts in windows and dialogs doesn't do anything REGRESSION: Keyboard shortcuts in windows and dialogs doesn't do anything Jan 14, 2019
@aecreations
Copy link
Owner Author

I have complained on the Mozilla Add-ons Blog in a comment to their blog post about the upcoming release of Firefox 65: https://blog.mozilla.org/addons/2018/12/20/extensions-in-firefox-65/#comment-225600

@aecreations
Copy link
Owner Author

According to MDN, the "keypress" event is deprecated: https://developer.mozilla.org/en-US/docs/Web/Events/keypress. The suggested replacement is "keydown" or "beforeinput".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Clippings 6.1
  
Done
Development

No branches or pull requests

1 participant