Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION: Clipping sometimes doesn't get pasted when using shortcut key #259

Closed
aecreations opened this issue Mar 28, 2019 · 1 comment
Closed

REGRESSION: Clipping sometimes doesn't get pasted when using shortcut key #259

aecreations opened this issue Mar 28, 2019 · 1 comment
Assignees
@aecreations
Labels
bug fixed
Projects
Clippings 6.1
Milestone
6.1.4.1

Comments

@aecreations
Copy link
Owner

Clippings 6.1.4 on Firefox 66

Users who have upgraded to Firefox 66 have reported that their clippings aren't being pasted when doing so by shortcut key. One user is on Linux, but I've been able to reproduce this on macOS.

The cause seems to be that the textbox in the web page is sometimes not getting the focus at the time the content script function handleRequestInsertClipping() is invoked by the background script.
@aecreations aecreations self-assigned this Mar 28, 2019
@aecreations aecreations added this to the 6.1.4.1 milestone Mar 28, 2019
@aecreations aecreations added this to In Progress in Clippings 6.1 Mar 28, 2019
aecreations added a commit that referenced this issue Mar 29, 2019
@aecreations
Bug fix: Clipping sometimes doesn't get pasted when using shortcut key
7b64c83 
(issue #259)
@aecreations aecreations moved this from In Progress to Done in Clippings 6.1 Mar 29, 2019
@aecreations
Copy link
Owner Author

This bug fix was also tested on Firefox 67.0b5, and is also confirmed fixed with that Firefox version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aecreations aecreations

Labels
bug fixed
Projects
No open projects
Clippings 6.1
  
Done
Milestone
6.1.4.1
Development

No branches or pull requests
1 participant
@aecreations