Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HTML insert to use the DOM Range API #436

Closed
aecreations opened this issue Jan 19, 2024 · 1 comment
Closed

Refactor HTML insert to use the DOM Range API #436

aecreations opened this issue Jan 19, 2024 · 1 comment
Assignees
@aecreations
Labels
fixed maintenance
Milestone
6.5.2 Modesto

Comments

@aecreations
Copy link
Owner

The content script that inserts an HTML-formatted clipping into a rich text editor uses document.execCommand("insertHTML"...), which is deprecated[1].

Refactor the code to use the DOM Range API: https://developer.mozilla.org/en-US/docs/Web/API/Range

--
[1] https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand
@aecreations aecreations self-assigned this Jan 19, 2024
@aecreations aecreations added this to the 6.5.2 Modesto milestone Jan 20, 2024
aecreations added a commit that referenced this issue Jan 20, 2024
@aecreations
Refactor HTML insert to use the DOM Range API (issue #436)
7084e42
aecreations added a commit that referenced this issue Jan 20, 2024
@aecreations
Added pref to control how HTML clippings are pasted (part of issue #436)
2d0d46b 
- Defaulting to the DOM Range API, but can be changed to revert to the deprecated document.execCommand API
@aecreations
Copy link
Owner Author

Unfortunately, this improvement doesn't resolve the issue with pasting HTML-formatted clippings into rich text editors that use the CKEditor library (issue #379).

@aecreations aecreations mentioned this issue Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aecreations aecreations

Labels
fixed maintenance
Projects
None yet
Milestone
6.5.2 Modesto
Development

No branches or pull requests
1 participant
@aecreations