Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcut set from Manage Extension Shortcuts not refreshed in extension prefs page when it is reset #88

Closed
aecreations opened this issue Sep 16, 2023 · 1 comment
Closed

Keyboard shortcut set from Manage Extension Shortcuts not refreshed in extension prefs page when it is reset #88

aecreations opened this issue Sep 16, 2023 · 1 comment
Assignees
@aecreations
Labels
bug fixed
Milestone
4.4.5 Islas Coronado

Comments

@aecreations
Copy link
Owner

Panic Button 4.4.4

Steps to repro:

  1. Open Add-ons Manager, then click on the gears icon and then select Manage Extension Shortcuts
  2. Change the keyboard shortcut for Panic Button to one that is not available from the drop-down menus in extension preferences; e.g., Command+. (period) on macOS
  3. Open the extension preferences page, then in the Keyboard Shortcut section, click Reset

Result: The keyboard shortcut is reset to the default (F8 key), but the display is not refreshed.
@aecreations aecreations self-assigned this Sep 16, 2023
@aecreations aecreations added this to the 5.0 Farallon milestone Sep 16, 2023
aecreations added a commit that referenced this issue Sep 25, 2023
@aecreations
Bug fix: Keyboard shortcut set from Manage Extension Shortcuts not re…
8cb7643 
…freshed in extension prefs page when it is reset

(issue #88)
- Also: minor code cleanup
@aecreations
Copy link
Owner Author

The above check-in was to the branches/5.0 branch (for the next version). This fix should be backported to the branches/4.4 branch.

aecreations added a commit that referenced this issue Sep 25, 2023
@aecreations
Bug fix: Keyboard shortcut set from Manage Extension Shortcuts not re…
4f8f966 
…freshed in extension prefs page when it is reset

(issue #88)
- Ported from Panic Button 5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aecreations aecreations

Labels
bug fixed
Projects
None yet
Milestone
4.4.5 Islas Coronado
Development

No branches or pull requests
1 participant
@aecreations