Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results not updated when adding a link #43

Closed
aecreations opened this issue Oct 1, 2022 · 1 comment
Closed

Search results not updated when adding a link #43

aecreations opened this issue Oct 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working fixed

Comments

@aecreations
Copy link
Owner

Read Next 0.8.4+

Steps to repro:

  1. Open the sidebar. Ensure there are a few links already added to the reading list
  2. Click on the search box and enter a search term to filter the reading list or cause the "No results" message to appear
  3. Navigate to any web page, and add it to the reading list

Result:
The new link appears in the search result, even if its page title doesn't match the search terms entered in the search box.

@aecreations aecreations added this to the 0.9 Makai milestone Oct 1, 2022
@aecreations aecreations self-assigned this Oct 1, 2022
@aecreations aecreations added the bug Something isn't working label Oct 1, 2022
@aecreations aecreations removed this from the 0.9 Makai milestone Oct 1, 2022
@aecreations aecreations added this to the 1.0.2 Mauna Loa milestone Mar 2, 2023
@aecreations
Copy link
Owner Author

aecreations commented Mar 5, 2023

If a new link is added to the reading list that doesn't match the search terms, it shouldn't show up in the search results.

Also, if the search result shows one link, and that link is deleted, the current behaviour is that the empty state UI is shown (it goes away when search is cancelled). Instead, the reading list sidebar should be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

1 participant