Tab titles display as "null" if Send Tab URLs invoked after browser session was restored #1

Closed
aecreations opened this Issue Mar 20, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@aecreations
Owner

aecreations commented Mar 20, 2014

The reason why the tab titles can't be retrieved is that Send Tab URLs currently looks at the document.title property within each browser tab. But this property is inaccessible after the browser session is restored because Firefox doesn't automatically reload the content in the inactive tab browsers; that is only done when the user clicks on a browser tab.

This issue is most noticable if the user has installed Panic Button, and has set the Panic Button action to either "Hide all windows" or "Hide and replace."

There was an attempt at fixing this issue in 2.1.1 which had a side effect of causing a blank browser tab to open when clicking on a link in a Gmail message (which is the reason why version 2.1.1 is no longer publicly available).

After digging around in the DOM Inspector in Firefox 27, I found a better way. The browser overlay code should do something similar to this:

let browserTabs = document.getElementById("tabbrowser-tabs").tabbrowser.tabs;
let tabTitle = browserTabs[i].label;   // where i is between 0 and browserTabs.length

Whatever approach is taken needs to be compatible with the Hide Tab Bar With One Tab extension.

@aecreations aecreations added the bug label Mar 20, 2014

@aecreations aecreations self-assigned this Mar 20, 2014

aecreations pushed a commit that referenced this issue Jun 9, 2014

@aecreations aecreations added the fixed label Jun 16, 2014

@aecreations

This comment has been minimized.

Show comment
Hide comment
@aecreations

aecreations Jun 29, 2014

Owner

This fix is confirmed to be working with Hide Tab Bar With One Tab, version 1.4. Tested on Firefox 30.

Owner

aecreations commented Jun 29, 2014

This fix is confirmed to be working with Hide Tab Bar With One Tab, version 1.4. Tested on Firefox 30.

@aecreations

This comment has been minimized.

Show comment
Hide comment
@aecreations

aecreations Oct 6, 2014

Owner

Fixed in 2.2

Owner

aecreations commented Oct 6, 2014

Fixed in 2.2

@aecreations aecreations closed this Oct 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment