-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : Add base to allow factory setup #375
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7298663 | Triggered | RSA Private Key | 3a26d06 | .env.template | View secret |
7298663 | Triggered | RSA Private Key | b923f6b | .env.template | View secret |
7298668 | Triggered | Generic High Entropy Secret | 3a26d06 | .env.template | View secret |
7298668 | Triggered | Generic High Entropy Secret | b923f6b | .env.template | View secret |
7298675 | Triggered | Generic High Entropy Secret | 3a26d06 | .env.template | View secret |
7298675 | Triggered | Generic High Entropy Secret | b923f6b | .env.template | View secret |
7298675 | Triggered | Generic High Entropy Secret | 3731e48 | .env.template | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 78.69% 77.72% -0.98%
==========================================
Files 81 84 +3
Lines 5459 5566 +107
==========================================
+ Hits 4296 4326 +30
- Misses 1163 1240 +77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think factories object should be classes inherit from the base Factory class
DATABASE_DEBUG = False #If True, will print all SQL queries in the console | ||
FACTORIES = False #If True, will use factories to populate the database with fake data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FACTORIES = False #If True, will use factories to populate the database with fake data | |
USE_FACTORIES = False # Enabling factories populate empty database with test data |
I think we could put this variable after USE_FIREBASE
def __init__( | ||
self, | ||
name: str, | ||
depends_on: list[str], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on a factory object instead of a string to have python check the values
f"Module {factories_file} does not declare a module. It won't be enabled.", | ||
) | ||
|
||
action = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should find a solution a bit less complicated
No description provided.