Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation: Improve image management in every module #309

Merged
merged 19 commits into from
Mar 12, 2024

Conversation

guillaumetavernier
Copy link
Contributor

@guillaumetavernier guillaumetavernier commented Mar 1, 2024

Change in this PR :

  • MapNotifier types is now Map<,> rather than AsyncChild<Map<>> (unnecessary abstraction)
  • AutoLoadChild now uses group given by the provider.select() clause, preventing unnecessary rebuild
  • Remove loadTList from the initialization of Image MapNotifier causing images reload on every list modification
  • Add Image Map management on add/edit/delete item related to the image

This PR affects :

  • admin
  • advert*
  • amap
  • cinema*
  • loan
  • vote*
  • loan
  • tombola*
  • vote*
  • Where most changes to image happen

@guillaumetavernier guillaumetavernier added core This PR change the core optimisation labels Mar 1, 2024
@guillaumetavernier guillaumetavernier changed the title Optimisation: Rework map notifier Optimisation: Improve image management in every module Mar 1, 2024
Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 56.86275% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 55.80%. Comparing base (3791c95) to head (59446d3).

Files Patch % Lines
lib/tools/providers/map_provider.dart 52.77% 17 Missing ⚠️
lib/cinema/providers/session_poster_provider.dart 71.42% 2 Missing ⚠️
.../cinema/providers/session_poster_map_provider.dart 0.00% 1 Missing ⚠️
lib/vote/providers/contender_logo_provider.dart 83.33% 1 Missing ⚠️
lib/vote/providers/contender_logos_provider.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   56.03%   55.80%   -0.23%     
==========================================
  Files         161      163       +2     
  Lines        3514     3505       -9     
==========================================
- Hits         1969     1956      -13     
- Misses       1545     1549       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 merged commit ec4d4ad into main Mar 12, 2024
7 checks passed
@julien4215 julien4215 deleted the Rework-MapNotifier branch March 12, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This PR change the core optimisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants