Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password format verification #373

Merged
merged 3 commits into from
Jun 4, 2024
Merged

password format verification #373

merged 3 commits into from
Jun 4, 2024

Conversation

Foukki
Copy link
Contributor

@Foukki Foukki commented May 23, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.87%. Comparing base (e819b9b) to head (742c92d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         169      169           
  Lines        3727     3727           
=======================================
  Hits         2008     2008           
  Misses       1719     1719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximeroucher maximeroucher added core This PR change the core waiting backend labels May 26, 2024
Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this logic in the validator of the password (line 89). Doing so will prevent the user to go on next page until conditions are matched, and in case of error, the message is displayed inside the page

@Foukki Foukki marked this pull request as draft May 30, 2024 11:35
@Foukki Foukki marked this pull request as ready for review May 31, 2024 07:15
lib/login/ui/components/login_field.dart Outdated Show resolved Hide resolved
@Foukki Foukki merged commit 58f7082 into main Jun 4, 2024
3 checks passed
@Foukki Foukki deleted the password-requirement branch June 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This PR change the core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants