Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Specific YCQL and YEDIS (and YSQL) proxy port binding flags #153

Merged
merged 3 commits into from Mar 12, 2020

Conversation

aegershman
Copy link
Owner

@aegershman aegershman commented Mar 11, 2020

Continues to evaluate some of the findings from the webserver_interface binding from this issue #53 (comment), except extending it to ycql and yedis

there seems to be solid benefit to just explicitly declaring the binding addresses for each of these proxy endpoints, rather than relying on 0.0.0.0 or perhaps an auto-parsing routine, so they will be explicitly declared based on the findings from these:

fun facts:

  • verified this does bind to the ports as expected by modifying the proxy bindings to something else and watching the sample apps flap
  • this could later be used by the sample-apps, etc., in order to consume the port bindings through direct bosh links

addresses #80
closes #81

I'm also go to see if I can freely tack on ysql, even though it's not in use... It's interesting since the yugabyte helm chart appears to use the pod ip: https://github.com/yugabyte/charts/blob/master/stable/yugabyte/templates/service.yaml#L287

@aegershman aegershman added this to In progress in yugabyte-boshrelease progress via automation Mar 11, 2020
@github-actions github-actions bot added the job/yb-tserver code changes affecting yb-tserver job label Mar 11, 2020
@aegershman aegershman added area/docs improvements or additions to documentation area/ycql things involving YCQL API priority/medium medium priority area/yedis things involving YEDIS API labels Mar 11, 2020
@aegershman aegershman changed the title Specific YCQL proxy port binding flags Specific YCQL and YEDIS proxy port binding flags Mar 11, 2020
@aegershman aegershman added the area/ysql things involving YSQL API label Mar 12, 2020
@aegershman aegershman changed the title Specific YCQL and YEDIS proxy port binding flags Specific YCQL and YEDIS (and YSQL) proxy port binding flags Mar 12, 2020
@aegershman aegershman merged commit b807e06 into master Mar 12, 2020
yugabyte-boshrelease progress automation moved this from In progress to Done Mar 12, 2020
@aegershman aegershman deleted the cql-binding-flags branch March 12, 2020 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs improvements or additions to documentation area/ycql things involving YCQL API area/yedis things involving YEDIS API area/ysql things involving YSQL API job/yb-tserver code changes affecting yb-tserver job priority/medium medium priority
Development

Successfully merging this pull request may close these issues.

consider adding yedis proxy binding flags, etc
1 participant