Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon: OMGSERV #492

Merged
merged 4 commits into from
Jan 26, 2022
Merged

New icon: OMGSERV #492

merged 4 commits into from
Jan 26, 2022

Conversation

Neluji
Copy link
Contributor

@Neluji Neluji commented Jan 23, 2022

URL of the site: https://www.omgserv.com

Logo / icon info: Logo manually traced from following sources (directly from website):

(See below for the difference)

Background color info: Color from the logo, can also be found here:
https://brandfetch.com/omgserv.com (#e53711)

IllustratorInkscape files (if you have any):

OMGSERV-src.zip

  • I have carefully read and followed CONTRIBUTING document.
  • I only added SVG(s) to the pull request.

⚠️ Important: I've added 2 version of the icon: one is based on the textual logo, it can be found in SVG/OMGSERV.svg ; the other one is based on the graphical logo (which is also the favicon of the website), it can be found in SVG/.Variations/OMGSERV alt.svg. As I did not not know which one is the more appropriate (I'm interested in knowing the best choice if I were to contribute again), I incorporated both, so you can chose between them.

@krisu5 krisu5 changed the title New icon: OMSERV New icon: OMGSERV Jan 24, 2022
@krisu5
Copy link
Member

krisu5 commented Jan 26, 2022

I've added 2 version of the icon: one is based on the textual logo, it can be found in SVG/OMGSERV.svg ; the other one is based on the graphical logo (which is also the favicon of the website), it can be found in SVG/.Variations/OMGSERV alt.svg. As I did not not know which one is the more appropriate (I'm interested in knowing the best choice if I were to contribute again), I incorporated both, so you can chose between them.

In this case, I don't consider the O "head" as its own logomark1 because it's part of the brand name. When logomarks are clearly seperate (eg. Apple, Microsoft etc.), that's when it's OK and prefer to only use logomark.

I personally don't count favicons as "official logos", so I almost never use/trace those for logos.

About the icon itself: I made logo slightly smaller and cleaned up the markup. Merging it after this comment.

Related to the markup, if you're gonna submit again, I made important changes to CONTRIBUTING doc for Inkscape users, see sections "Save and export" and "SVG compression & cleanup". I had some mistakes before related to Inkscape and finally there's explanation how SVG code should be formatted.

Footnotes

  1. https://blog.designcrowd.com/article/997/logo-logomark-logotype-whats-the-difference-and-what-do-you-need

@krisu5 krisu5 merged commit 7f3020c into aegis-icons:master Jan 26, 2022
@Neluji
Copy link
Contributor Author

Neluji commented Jan 28, 2022

I've added 2 version of the icon: one is based on the textual logo, it can be found in SVG/OMGSERV.svg ; the other one is based on the graphical logo (which is also the favicon of the website), it can be found in SVG/.Variations/OMGSERV alt.svg. As I did not not know which one is the more appropriate (I'm interested in knowing the best choice if I were to contribute again), I incorporated both, so you can chose between them.

In this case, I don't consider the O "head" as its own logomark1 because it's part of the brand name. When logomarks are clearly seperate (eg. Apple, Microsoft etc.), that's when it's OK and prefer to only use logomark.

I personally don't count favicons as "official logos", so I almost never use/trace those for logos.

About the icon itself: I made logo slightly smaller and cleaned up the markup. Merging it after this comment.

Related to the markup, if you're gonna submit again, I made important changes to CONTRIBUTING doc for Inkscape users, see sections "Save and export" and "SVG compression & cleanup". I had some mistakes before related to Inkscape and finally there's explanation how SVG code should be formatted.

Ok, thanks for the explanations 🙂

Footnotes

  1. https://blog.designcrowd.com/article/997/logo-logomark-logotype-whats-the-difference-and-what-do-you-need

@Neluji Neluji deleted the omgserv-icon branch January 29, 2022 15:52
krisu5 pushed a commit that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants