Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon: Passmulticadeaux #806

Merged
merged 5 commits into from Feb 1, 2023

Conversation

Dampypena
Copy link
Contributor

@Dampypena Dampypena commented Jan 15, 2023

URL of the site:
https://www.passmulticadeaux.fr/

Proof of the Aegis-compatible 2FA:

PassMultiCadeauOTP

Logo / icon info:
I retrieved the logo from the google play application. I converted it in SVG using Convertio.

Background color info:
The color was extracted from the footer of the website #74195a

image

Copy link
Member

@krisu5 krisu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear what's the actual spelling of the name, but I changed it to Passmulticadeaux instead based of Google Play Store page (usually I don't use that as source, but this time I had limited options).

The color was extracted from the footer of the website #74195a

Use one of the colors of the logo (preferably violet, since its most used color on that logo).

I converted it in SVG using Convertio.

This tool's image tracing is mediocre, don't use it. I have tested many of the image tracing tools and don't recommend most of them.

If you have to use image trace (please search for vector logos first, don't use it as first option), use Vectorizer.io with mentioned instructions here (at end of the "Finding source images" section).


I added info to CONTRIBUTING about not using other image tracers except the currently recommended ones.

@krisu5 krisu5 changed the title New icon: PassMultiCadeau New icon: Passmulticadeaux Jan 15, 2023
@Dampypena
Copy link
Contributor Author

I changed the color to #8139aa, the violet from the logo.

krisu5
krisu5 previously requested changes Jan 29, 2023
Copy link
Member

@krisu5 krisu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but logo is still the one that was made with unacceptable image tracing tool.

Please recreate the logo from image with one of the tools here.

@Dampypena
Copy link
Contributor Author

I changed the logo by using Vectorizer.io. Tell me if it needs to be modified. I'm using Inkscape.

@krisu5 krisu5 dismissed their stale review February 1, 2023 17:53

I fixed it myself

@krisu5
Copy link
Member

krisu5 commented Feb 1, 2023

TBH, it was even worse for some reason, I guess Vectorizer.io isn't good at small images. Vector Magic (and Vectorizer.AI) are better at that.

I fixed it myself with Vector Magic and manually fixing the some parts.

See the difference: before (your last revision) and after. Less janky lines and file size is also over 60% smaller because of changes.

@krisu5 krisu5 merged commit 8212ad7 into aegis-icons:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants