Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom nav icons have weird artifacts (tiny spikes) #215

Closed
fer0n opened this issue Jul 3, 2023 · 14 comments
Closed

Bottom nav icons have weird artifacts (tiny spikes) #215

fer0n opened this issue Jul 3, 2023 · 14 comments

Comments

@fer0n
Copy link
Contributor

fer0n commented Jul 3, 2023

If you look at the bottom navigation icons closely, you can see some tiny spikes which most likely aren't there on purpose:

"Posts" close up
Bottom Nav

@fer0n fer0n changed the title Bottom nav icons have weird artifacts Bottom nav icons have weird artifacts (tiny spikes) Jul 3, 2023
@aeharding
Copy link
Owner

Phone model and OS version?

@fer0n
Copy link
Contributor Author

fer0n commented Jul 3, 2023

Device: iPhone 12 Pro
OS: iOS 16.6
Version: 0.11.1

@aeharding
Copy link
Owner

I can replicate in https://ionic-react-conference-app.firebaseapp.com/about.

Therefore, I believe this is an Ionic or Ion Icons bug. Please make an issue with one of those projects and tag this issue so we can stay informed :)

@fer0n
Copy link
Contributor Author

fer0n commented Jul 3, 2023

@aeharding
Copy link
Owner

Thanks!

If you can confirm that workaround works, feel free to make a pr

fer0n pushed a commit to fer0n/wefwef that referenced this issue Jul 4, 2023
aeharding pushed a commit that referenced this issue Jul 4, 2023
Co-authored-by: Michael Förg <michael.foerg@pentlandfirth.com>
@aeharding aeharding reopened this Jul 4, 2023
@aeharding
Copy link
Owner

Reopening, I still get jagged icons

@fer0n
Copy link
Contributor Author

fer0n commented Jul 4, 2023

I'll have another look tomorrow, for me it was definitely gone but maybe I was missing something. Sorry for the inconvenience

@fer0n
Copy link
Contributor Author

fer0n commented Jul 4, 2023

What device were you testing it on @aeharding?

@aeharding
Copy link
Owner

I'm using an iPhone 13 mini. Should be using latest iOS :)

@fer0n
Copy link
Contributor Author

fer0n commented Jul 5, 2023

I had another look, the fix works on the iOS Simulator and on macOS in Safari.
Simulator Screen Shot - iPhone 13 mini.

However, no matter what I do I can't get it to work on the actual iPhone. I guess we'll have to hope that the ionicon issue will be fixed or maybe a newer iOS Version will fix it. In the mean time, if you think it's worth having that line to fix it on desktop safari you could enable it again, but otherwise I think we're out of luck, sorry.

@fer0n
Copy link
Contributor Author

fer0n commented Jul 5, 2023

Maybe there's another way to solve this, but it's probably not going to be as clean as the first approach. I'll see what solution I can come up with and then you can decide if it's worth merging

@fer0n
Copy link
Contributor Author

fer0n commented Jul 6, 2023

@aeharding I opened a PR (#281) for the new fix, as I mentioned it's not as clean and quick as the first one, but the best solution I could come up with.

@aeharding
Copy link
Owner

@fer0n can you confirm if this is solved for you in latest iOS?

@fer0n
Copy link
Contributor Author

fer0n commented Mar 8, 2024

@aeharding Yes, the issue is gone 🎉
Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants