-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom nav icons have weird artifacts (tiny spikes) #215
Comments
Phone model and OS version? |
Device: iPhone 12 Pro |
I can replicate in https://ionic-react-conference-app.firebaseapp.com/about. Therefore, I believe this is an Ionic or Ion Icons bug. Please make an issue with one of those projects and tag this issue so we can stay informed :) |
Thanks! If you can confirm that workaround works, feel free to make a pr |
Reopening, I still get jagged icons |
I'll have another look tomorrow, for me it was definitely gone but maybe I was missing something. Sorry for the inconvenience |
What device were you testing it on @aeharding? |
I'm using an iPhone 13 mini. Should be using latest iOS :) |
I had another look, the fix works on the iOS Simulator and on macOS in Safari. However, no matter what I do I can't get it to work on the actual iPhone. I guess we'll have to hope that the ionicon issue will be fixed or maybe a newer iOS Version will fix it. In the mean time, if you think it's worth having that line to fix it on desktop safari you could enable it again, but otherwise I think we're out of luck, sorry. |
Maybe there's another way to solve this, but it's probably not going to be as clean as the first approach. I'll see what solution I can come up with and then you can decide if it's worth merging |
@aeharding I opened a PR (#281) for the new fix, as I mentioned it's not as clean and quick as the first one, but the best solution I could come up with. |
@fer0n can you confirm if this is solved for you in latest iOS? |
@aeharding Yes, the issue is gone 🎉 |
If you look at the bottom navigation icons closely, you can see some tiny spikes which most likely aren't there on purpose:
The text was updated successfully, but these errors were encountered: