Add option to collapse comments recursively by default #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for the PR! It looks like there are some lint issues preventing successful build. I'll try to review this as soon as I have time. |
|
Thanks, I moved it to draft when I saw it failed those checks. I've been away but I'll take a look when I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1153 and adds an option to cause comments and all children to start collapsed.
Determining which mode is selected to fetch the correct depth of comments when tapping "n more replies" turned out to be tricky, and I ended up creating a new app selector rather than modifying defaultCommentDepthSelector. Maybe not the most elegant solution but I didn't want to risk messing with other comment behavior.
Since the "Always" setting was changed to "Root Only", a database migration was required.
Please let me know how I did. This is my first contribution on GitHub and my first experience with TypeScript.