-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sharing/previewing links and embeds in ios #337
Conversation
325a589
to
54763df
Compare
I'm on iOS 15.7.7 and wefwef is on 0.17.0. I am still having no effect on tap and hold despite updating to this new version. When I tap and hold an image, nothing happens, I move my finger around and it takes the image around, but no menu opens up to give me the option to share the image directly or anything like what @Penagwin shared on their video. As of right now, for me to share an image directly rather than a link, I'm taking a screenshot, cropping it and sharing that. tap_and_hold.mp4 |
@raziel2701 When you clicked on the image that opened the "gallery" and I'll be honest I'm not sure if it's working there. The changes I made was to the image you see on the feed, and the image you see on the post, I didn't change the one in the gallery. I should double check to make sure it's working correctly in the compact-feed. @aeharding Would you like the ios select-hold on images to work on the gallery too? I also noticed on my "official" pwa install that if you tap-hold really quickly then it will do the ios thing, but also open the gallery in the background. It didn't do that locally for me, is anyone able to replicate this? |
@raziel2701 Forgot to ask - does it work on the other images that you see on the feed and the post - not from the gallery screen? And are you able to test my PR branch by chance and see if it's working with links for you (both embeds and blue links). |
@Penagwin It doesn't work anywhere I've tried inside the app. I'm not able to test your PR unfortunately. |
I don't see why not. I'd prefer to be consistent with any pictures in the app (that aren't small avatars) |
Let's do this: I did double check and the click-hold does work on the gallery images to, so it should be consistent everywhere. @raziel2701 I don't have a device with ios 15 - it's possible that feature isn't available on ios 15 D: Let's move discussion about the images specifically to #69 @aeharding This specific PR for the links and embeds should be good to go if you're able to test it (and would like it I suppose :P ). |
54763df
to
7ec10c9
Compare
@aeharding I removed the webkit-tap-highlight-color |
Similar to #226 it allows the web-preview/sharing for both embeds and the markdown links.
Same as the last PR - I don't think this interferes with any existing gestures.
Also helps #69
I wasn't 100% sure if the link interceptor is where you wanted this to be, or if I did it in the style you prefer.
embed_sharing_ios_demo.mp4