Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bypassing the proxy for some Lemmy instances #338

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Support bypassing the proxy for some Lemmy instances #338

merged 2 commits into from
Jul 9, 2023

Conversation

geneccx
Copy link
Contributor

@geneccx geneccx commented Jul 9, 2023

Since LemmyNet/lemmy#3421 was merged, Lemmy instances on 0.18.1 and newer allow cross-origin requests.

Notably missing is lemmy.world, which currently is broken as it sends double CORS headers:

> fetch('https://lemmy.world/api/v3/posts/list');

Access to fetch at 'https://lemmy.world/api/v3/posts/list' from origin 'https://wefwef.app' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header contains multiple values 'https://wefwef.app, *', but only one is allowed. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Since LemmyNet/lemmy#3421 was merged, Lemmy instances on 0.18.1
and newer allow cross-origin requests.
@aeharding
Copy link
Owner

aeharding commented Jul 9, 2023

Added fix for image upload. Otherwise LGTM!

(related bug: LemmyNet/lemmy#3567)

@aeharding aeharding merged commit 351fa29 into aeharding:main Jul 9, 2023
2 checks passed
@geneccx geneccx deleted the bypass-proxy branch July 9, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants