Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add share gesture #705

Merged
merged 3 commits into from
Oct 29, 2023
Merged

feat: add share gesture #705

merged 3 commits into from
Oct 29, 2023

Conversation

80avin
Copy link
Contributor

@80avin 80avin commented Aug 21, 2023

Adds share gesture for Post, Comment, Inbox

Fixes: #696

Currently, there's an intermittent issue described here: #696 (comment)

@aeharding
Copy link
Owner

Thanks for the PR!

I'm going to mark this blocked until that gesture issue is resolved.

@aeharding aeharding marked this pull request as ready for review October 29, 2023 16:18
@aeharding aeharding removed the blocked label Oct 29, 2023
@aeharding
Copy link
Owner

I've worked around this issue by only enabling the share gesture on native clients. :)

We can enable share gesture from PWA in the future if browsers allows dragend to trigger share popup

@aeharding aeharding merged commit 84fb9a6 into aeharding:main Oct 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share Gesture
2 participants