feat: add a way to quickly subscribe from search results

[sharunkumar]

This is especially helpful when using the "Migrate Subreddits" feature

Other features in this PR:

• long pressing community link has an option to open the sidebar
• refactor code to have a common hook for community actions useCommunityActions

(Color scheme in the screenshot is from #711)

[SrivatsanSenthilkumar]

This may be just my subjective opinion but the design does not match with the rest of the UI. Something with a similar design to the star shaped indicator/button used for marking a community as favourite will work better in opinion. A heart shaped indicator (maybe a hollow design with borders to improve indicator visibility) when the community is not subscribed to and solid when you are subscribed to the community.

[sharunkumar]

I just went with the heart because that was the icon used for subscribe when log pressing a community. Open to suggestions from @aeharding

[SrivatsanSenthilkumar]

I want it to be a heart as well. Just that it follows the same design language as the star(that is a empty translucent heart to denote not subscribed and a filled heart to indicate subscribed) for UI design consistency across the app

[sharunkumar]

@SrivatsanSenthilkumar I tried it with the same style as the star but it seems like its barely visible in dark mode:

I've committed the changes to another branch for now: sharunkumar@ff1a9d6

if this is fine, ill merge it into the PR

[SrivatsanSenthilkumar]

Hmmm true. It is barely visible in the dark mode. The star for favouriting has the same issue. Maybe there can be border (if possible the same colour as the accent colour) to improve legibility.

Please ignore my horrendous drawing skill

Edit : If this looks good maybe I will open an issue related to adding a border on the star as well.

[sharunkumar]

Got it, this is what it would look like:

Alternatively:

not sure which version to add to this PR though 🤔

[SrivatsanSenthilkumar]

Both of them look great. I will open a poll on the voyager community to ascertain which design is preferred.

Also you have my thanks man. You are doing great work here and it's people like you who drive the open source community forward

[SrivatsanSenthilkumar]

Got it, this is what it would look like:

Alternatively:

not sure which version to add to this PR though 🤔

The first one is the unanimous winner. Nobody voted for the second design.

[sharunkumar]

Nobody voted for the second design.

yeah I had noticed 😅 I'll push the relevant changes to this PR

[sharunkumar]

@SrivatsanSenthilkumar @aeharding I could make a similar change to the star icon too:

[aeharding]

Hey, thanks for the PR! So I'm just taking my initial review of this. Regarding the UI, I'd like to match what we do for coloring/filled state for the star UI on the existing communities list page. I think it would be good to keep this consistent - and this is the UI that Apollo has. (The greyed out stars also reduce noise in the UI)

[sharunkumar]

I haven't updated the stars in the UI, it was just a mock up using local dev changes. Should I change the hearts to be faded too?

[aeharding]

I can take a look shortly, but yeah! :)

[arunsathiya]

Did you mean to include this fly.toml exclusion?

[sharunkumar]

to prevent myself from accidentally committing mine to this PR ;)

[sharunkumar]

Not sure what's causing this, but when I navigate to a community page, the console shows this error

[aeharding]

@sharunkumar I removed the local state from the useCommunityActions file. Instead I use the redux source of truth. The reason why it wasn't working is the data received from the search API for the community list wasn't populating the redux store. Check it out and let me know what you think

[sharunkumar]

@sharunkumar I removed the local state from the useCommunityActions file. Instead I use the redux source of truth. The reason why it wasn't working is the data received from the search API for the community list wasn't populating the redux store. Check it out and let me know what you think

got it, I checked it in my local and it seems to be working as expected 👍

[sharunkumar]

🚀