Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remember previously used links for migration #933

Merged
merged 33 commits into from
Feb 17, 2024

Conversation

sharunkumar
Copy link
Contributor

@sharunkumar sharunkumar commented Nov 14, 2023

Screenshot_20231114_123121_Chrome

@aeharding
Copy link
Owner

Thanks for the PR. I think this makes sense but we should have a slightly more iOS friendly design.

I also think that we should disable this feature unless the app is installed, just for privacy reasons.

I'm happy to take a look at the iOS styles, soon :)

Repository owner deleted a comment from sonarcloud bot Feb 12, 2024
@aeharding
Copy link
Owner

Hi @sharunkumar!

Thanks for your patience. I just had some time to take a look. I refactored a few things:

  1. Split up views into separate pages so swiping works properly
  2. Added swipe to forget, so you can only clear what you want. It also cleans up the UI a little bit and makes it similar to the filters/blocks UI.
  3. The paste for migrate link is now in an alert. It's a few more taps, but now that it is remembered, I don't think it's that big a deal.

If you could try it out, and let me know what you think, I would appreciate it and we can finally get this merged.

Thanks!

@sharunkumar
Copy link
Contributor Author

Looks good! Thanks for the update :D

@aeharding aeharding merged commit 19e4f5c into aeharding:main Feb 17, 2024
2 checks passed
@sharunkumar sharunkumar deleted the migrate-remember branch February 19, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants