Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for blocking communities #191

Closed
wants to merge 0 commits into from
Closed

Conversation

mdecourcy
Copy link
Contributor

No description provided.

@mdecourcy
Copy link
Contributor Author

Let me know if I should be feature branching, so my PRs don't include already merged requests.

@rsammelson
Copy link
Contributor

Can you fix the type checking issues?

@mdecourcy
Copy link
Contributor Author

mdecourcy commented Jul 3, 2023

Can you fix the type checking issues?

Done, also resolved merge conflict.

E: Didn't get them all, apparently. Unsure why my vscode isn't picking them up on my local.

@mdecourcy
Copy link
Contributor Author

Might be worth adding a warning modal before applying the block.

@aeharding
Copy link
Owner

Hi! Thanks for the PR.

The main problem with this is there is no block list in settings to undo. So we cannot merge that until user settings is implemented. But that is a larger scope thing that needs to wait atm.

That's why this PR is not going to be merged yet.

@mdecourcy
Copy link
Contributor Author

mdecourcy commented Jul 4, 2023

@aeharding

I can add that. Perhaps with an ion iOS list, similar to what is in the settings page?

As for the unblock buttons, red circle similar to the remove/log out of user flow?

Edit: reread your comment, if you believe this should wait no worries!

@aeharding
Copy link
Owner

BTW, I haven't forgotten about this! I will be working on some user configuration settings stuff shortly and then we can get this in.

@mdecourcy mdecourcy closed this Jul 6, 2023
@mdecourcy mdecourcy force-pushed the main branch 2 times, most recently from 5ba9b65 to 5ab4a59 Compare July 6, 2023 03:37
@aeharding
Copy link
Owner

Did you mean to close this @mdecourcy?

@mdecourcy
Copy link
Contributor Author

Apologies reopened in #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants