Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load vcf bgz #238

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Load vcf bgz #238

merged 7 commits into from
Apr 15, 2024

Conversation

ChristinaXu2017
Copy link
Collaborator

@ChristinaXu2017 ChristinaXu2017 commented Apr 4, 2024 •
edited
Loading

  • created a java method au.csiro.variantspark.utils. FileUtils.isBGZFile(String filePath).

    • it checks whether an input file is VCF BGZP file or not.
    • it calls method of BlockCompressedInputStream.isValidFile(bufferedInputStream);

  • apply above method to au.csiro.variantspark.cli.args.SparkApp.textFile(inputFile: String)

    • it calls sc.textFile(...) for non BGZIP input
    • it calls sc.parallelize(...) for BGZIP input

  • regression test may require to be update to test input in .vcf, .vcf.bz2, .vcf.gz and .vcf.bgz

bhosking
bhosking reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@bhosking bhosking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cleaning up, the logic is fine.

src/main/java/au/csiro/variantspark/utils/FileUtils.java Outdated Show resolved Hide resolved
src/main/java/au/csiro/variantspark/utils/FileUtils.java Outdated Show resolved Hide resolved
src/main/java/au/csiro/variantspark/utils/FileUtils.java Outdated Show resolved Hide resolved
src/main/scala/au/csiro/variantspark/cli/args/SparkArgs.scala Show resolved Hide resolved
ChristinaXu2017
ChristinaXu2017 commented Apr 11, 2024
View reviewed changes
Copy link
Collaborator Author

@ChristinaXu2017 ChristinaXu2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brendon, could you please approve this pull request if no further action requires.

@bhosking bhosking merged commit 2fb2642 into master Apr 15, 2024
1 check passed
@bhosking bhosking deleted the load_vcf_bgz branch April 15, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhosking bhosking bhosking left review comments

Assignees

@bhosking bhosking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChristinaXu2017 @bhosking