Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#r for Nuget Package with Version having 0 as last digit #106

Closed
NathanielACollier opened this issue Jun 5, 2017 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@NathanielACollier
Copy link

It looks like if a nuget package has a 0 as the last digit in it's version then RoslynPad or something creates a #r without the .0. An example is nuget package DocumentFormat.OpenXml.

When I pulled it in with RoslynPad it made a #r of:
#r "$NuGet\DocumentFormat.OpenXml\2.5\lib\DocumentFormat.OpenXml.dll"

The package filepath is
%userprofile%.nuget\packages\documentformat.openxml\2.5.0
so manually changing the #r to the below made the code work:
#r "$NuGet\DocumentFormat.OpenXml\2.5.0\lib\DocumentFormat.OpenXml.dll"

@aelij aelij self-assigned this Jun 6, 2017
@aelij aelij added the bug label Jun 6, 2017
@aelij
Copy link
Member

aelij commented Jun 6, 2017

Thanks for reporting this. Must be a problem with the new implementation of the NuGet v4 libraries (they removed a crucial virtual method I was using, so I had to find a workaround).

I'm rewriting most of RP using net-standard libraries, so NuGet will have to change as well anyhow.

@aelij aelij closed this as completed in 5b65ef0 Aug 8, 2017
@aelij aelij modified the milestone: 13 Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants