-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goss doesn't escape output in generated JUnit XML #203
Comments
AlexandreCarlton
added a commit
to AlexandreCarlton/goss
that referenced
this issue
Mar 11, 2017
Previously, characters such as '>' in tests were not escaped in the generated JUnit XML output (resulting in malformed output). Now, such characters are escaped. References goss-org#203
+1 |
AlexandreCarlton
added a commit
to AlexandreCarlton/goss
that referenced
this issue
Apr 22, 2017
Colour output is currently interfering with the XML escaping, so we remove it. References goss-org#203
aelsabbahy
pushed a commit
that referenced
this issue
Apr 23, 2017
* Escape special characters in JUnit XML output Previously, characters such as '>' in tests were not escaped in the generated JUnit XML output (resulting in malformed output). Now, such characters are escaped. References #203 * Disable colour in JUnit output Colour output is currently interfering with the XML escaping, so we remove it. References #203
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this issue
May 28, 2020
* Escape special characters in JUnit XML output Previously, characters such as '>' in tests were not escaped in the generated JUnit XML output (resulting in malformed output). Now, such characters are escaped. References goss-org#203 * Disable colour in JUnit output Colour output is currently interfering with the XML escaping, so we remove it. References goss-org#203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When generating JUnit XML, Goss does not escape special characters which can result in malformed XML.
As an arbitrary example:
The resulting XML is:
Notably, the
>
and'
characters are not escaped in both the text ofsystem-out
and thename
attribute oftestcase
. It would be really great if that could be fixed. :)The text was updated successfully, but these errors were encountered: